Move PushStreamContent Namespace #467
Conversation
Previous behavior caused issues of �mbiguous reference around PushStreamContent when both Refit and System.Net.Http.Formatting are included in a project. This is essentially a show stopper to upgrading to the latest Refit. The solution is to change the internal implementation of PushStreamContent namespace from System.Net.Http -> Refit.Net.Http and to update the usages internally. Note this may be a breaking change to those who have taken a dependency on PushStreamContent in their own projects from the Refit assemblies.
|
Setting an assembly extern Refit;This will allow you to access the version of Feel free to merge or close this depending on your thoughts. |
|
@onovotny I would say that this should probably make its way into the |
|
TBD...we may want to still rename since aliases aren't very easy to use with PackageReference currently. I don't really see the harm in renaming the types internally. |
|
|
|
Should we be moving to a different namespace, or can we just use the one from |
|
@bennor System.Net.Formatting is part of ASP.NET and does not seem to be .NET Standard: https://github.com/aspnet/AspNetWebStack/blob/master/src/System.Net.Http.Formatting/System.Net.Http.Formatting.csproj It is not even released as a NuGet.
|
|
In that case we don't have a lot of choice, do we. 😂 |
Refit/PushStreamContent.cs
Outdated
| using System.Net.Http; | ||
|
|
||
| namespace System.Net.Http | ||
| namespace Refit.Net.Http |
There was a problem hiding this comment.
Why change the namespace? Why not just make the types internal?
Previous behavior caused issues of ambiguous reference around
PushStreamContentwhen bothRefitandSystem.Net.Http.Formattingareincluded in a project. This is essentially a show stopper to upgrading
to the latest
Refit.The solution is to change the internal implementation of PushStreamContent
namespace from
System.Net.Http->Refit.Net.Httpand to updatethe usages internally. Note this may be a breaking change to those who
have taken a dependency on
PushStreamContentin their own projects fromthe
Refitassemblies.