Fixes #627, #637 and relates to #573 #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from master
…Message into getToken() as OAuth signature generation may rely on having access to properties in the request (example: Twitter reuest signing)
Member
|
The way this is structured, it would be a breaking change. Is there a way you can restructure it so it's additive? |
Member
Author
|
Stand by 🙂 |
added 2 commits
March 15, 2019 18:21
…itive, which is not possible without modifying the handler. So, creatingf a handler explicitly with a method type to support passing HttpRequestMessage in, and then users can choose to use this whenever their getToken method requires access to the HttpRequestMessage.
…tive as @onovotny requested.
Member
Author
|
PR updated with additive class, ready to merge. |
… in non-get methods.
Updating branch
Member
|
The code and tests look good. Can you please update the docs with the appropriate changes to reflect the new functionality and then I can merge? |
Member
Author
|
Done! |
Member
|
Can you doc the auth updates too? There are a few things in this PR. |
…here signature generation is dependent on contents of the HTTP request
Member
Author
|
Completed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the signature for AuthorizedHeaderValueGetter to support passing a HttpRequestMessage to the function