Fix #625: xml output encoding don't match writer setting #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| using (var writer = XmlWriter.Create(output, settings.XmlReaderWriterSettings.WriterSettings)) | ||
| using (var writer = XmlWriter.Create(stream, settings.XmlReaderWriterSettings.WriterSettings)) | ||
| { | ||
| var encoding = settings.XmlReaderWriterSettings.WriterSettings?.Encoding ?? Encoding.Unicode; |
Member
There was a problem hiding this comment.
What should the default be? Unicode or UTF8? Any reason for Unicode over UTF8 as the default?
Contributor
Author
There was a problem hiding this comment.
StringWriter default encoding is Unicode, so I keep it, and utf-16 is the previous behavior
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #625