Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix #641 NullReferenceException on Error, when Response.Content.Headers is null #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clairernovotny merged 2 commits into from
Apr 8, 2019
Merged

fix #641 NullReferenceException on Error, when Response.Content.Headers is null #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccd5b6b
add test to simulate issue
Styxxy Apr 7, 2019
ac4188e
check for null values in handling (exception) content
Styxxy Apr 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Refit.Tests/ResponseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,24 @@ public async Task ThrowsValidationException()
Assert.Equal(1, actualException.Content.Status);
Assert.Equal("title", actualException.Content.Title);
Assert.Equal("type", actualException.Content.Type);
}

[Fact]
public async Task BadRequestWithEmptyContent_ShouldReturnApiException()
{
var expectedResponse = new HttpResponseMessage(HttpStatusCode.BadRequest)
{
Content = new StringContent("Hello world")
};
expectedResponse.Content.Headers.Clear();

mockHandler.Expect(HttpMethod.Get, "http://api/aliasTest")
.Respond(req => expectedResponse);

var actualException = await Assert.ThrowsAsync<ApiException>(() => fixture.GetTestObject());

Assert.NotNull(actualException.Content);
Assert.Equal("Hello world", actualException.Content);
}
}
}
2 changes: 1 addition & 1 deletion Refit/ApiException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public static async Task<ApiException> Create(HttpRequestMessage message, HttpMe
exception.ContentHeaders = response.Content.Headers;
exception.Content = await response.Content.ReadAsStringAsync().ConfigureAwait(false);

if (response.Content.Headers.ContentType.MediaType.Equals("application/problem+json"))
if (response.Content.Headers?.ContentType?.MediaType?.Equals("application/problem+json") ?? false)
{
exception = await ValidationApiException.Create(exception).ConfigureAwait(false);
}
Expand Down