adds support for PATCH method out of the box #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaisbetts
added a commit
that referenced
this pull request
Jan 15, 2015
adds support for PATCH method out of the box
Member
|
👍 Thanks @cristi-badila! |
Contributor
Contributor
Author
|
@paulcbetts glad to help, but unfortunately there is a small issue in my pull request (I initially set the method for the attribute to "Patch" and then updated it to "PATCH" but I forgot to update the corresponding specs which now fail since they expect to find the method "Patch"). Should I open another pull request for this? Sorry for the inconvenience. |
Member
|
@cristi-badila Yep, no worries on the extra PRs, they're free of charge! |
anaisbetts
added a commit
that referenced
this pull request
Jan 20, 2015
fixes bad specs introduced in #115
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.