chore: minor refactor #1625
Merged
chore: minor refactor #1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1625 +/- ##
==========================================
- Coverage 87.81% 87.73% -0.08%
==========================================
Files 33 33
Lines 2347 2348 +1
Branches 294 294
==========================================
- Hits 2061 2060 -1
- Misses 207 208 +1
- Partials 79 80 +1 ☔ View full report in Codecov by Sentry. |
cd469bd to
6571dfb
Compare
6571dfb to
8a4d978
Compare
ChrisPulman
approved these changes
Jan 5, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToListtoToArray- attempted to refactor the method to not create closures but it didn't make an impact on memory usage 🤷TryGetValueDoNotConvertToQueryMapmadeShouldReturnstatic and removed unneeded calls to itFollow up to #1619