feat: optimize RestMethodInfo, reduce dictionary allocations and li…
#1742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParameterInfoMaptoParameterInfoArray.Headers,HeaderParameterMap,PropertyParameterMap,QueryParameterMap,AttachmentNameMapto only allocate a dictionary when needed.Emptydictionary is a little risky but I dont see why we'd ever want to mutate the collection.EmptyDictionary<TKey, TValue>.get()to create static empty dictionaries. I would prefer to useImmutableDictionary.Emptyand changeDictionarytoIReadOnlyDictionarybut they aren't available in . Net Framework.bodyParamEnumerableandauthorizeParamsEnumerablenow use a tuple instead of an anonymous class.HeaderCollectionParameterIndexinstead of the hashsetHeaderCollectionParameterMapWe could probably get away with using arrays instead of
Dictionary<int, TSomething>they would use less memory in most cases and would have faster lookups for smaller numbers.Saves 4Kb of memory, I might be able to do more after profiling.
Original
Changes