feat: calculate path substitutions in RestMethodInfo#1897
Merged
ChrisPulman merged 2 commits intoreactiveui:mainfrom Nov 3, 2024
Merged
feat: calculate path substitutions in RestMethodInfo#1897ChrisPulman merged 2 commits intoreactiveui:mainfrom
RestMethodInfo#1897ChrisPulman merged 2 commits intoreactiveui:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1897 +/- ##
==========================================
- Coverage 87.73% 84.89% -2.85%
==========================================
Files 33 36 +3
Lines 2348 2502 +154
Branches 294 361 +67
==========================================
+ Hits 2060 2124 +64
- Misses 208 299 +91
+ Partials 80 79 -1 ☔ View full report in Codecov by Sentry. |
7f1b9b4 to
8058ac1
Compare
8058ac1 to
97cc2b0
Compare
97cc2b0 to
62ea4bf
Compare
ChrisPulman
approved these changes
Nov 3, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse the url target inside
RestMethodInfo, removing the use of regex on function calls.Re attempt at #1730. Turns out the additional allocations were caused by line 829 creating a closure. Looking at the lowered code C# always created the linq closure, even when round tripping was never used 🤔
In future I could optimise round trip to not use
string.Split, either manually splitting or usingSpan.SplitBenchmarks (on battery power)
Old benchmarks