feat: test Named HttpClient reuse by AddRefitClient #1910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Moore <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1910 +/- ##
==========================================
- Coverage 87.73% 84.94% -2.80%
==========================================
Files 33 36 +3
Lines 2348 2504 +156
Branches 294 363 +69
==========================================
+ Hits 2060 2127 +67
- Misses 208 299 +91
+ Partials 80 78 -2 ☔ View full report in Codecov by Sentry. |
TimothyMakkison
approved these changes
Nov 6, 2024
ChrisPulman
approved these changes
Nov 6, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds a test to confirm and conform Refit.HttpClientFactory's AddRefitClient with respect to named HttpClients.
Fixes #1909
What is the current behavior?
AddRefitClient can reuse existing named clients, but it can also reconfigure the named clients' factories.
What is the new behavior?
No new behavior, just a test confirming that existing behavior is to pick up named clients.
What might this PR break?
Nothing
Please check if the PR fulfills these requirements
Other information:
Docs could be updated further to make it clear that AddRefitClient will use named clients and that you will reconfigure the named client's factory if you use AddRefitClient's returned IHttpClientBuilder (as described in #1686).