Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: replace Append with WriteLine and remove blank spaces #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChrisPulman merged 1 commit into from
Apr 5, 2025
Merged

fix: replace Append with WriteLine and remove blank spaces #1967

ChrisPulman merged 1 commit into from
Apr 5, 2025

Conversation

@TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Apr 4, 2025 •
edited
Loading

  • Update Emitter logic
  • Remove blank line before the classes body
  • tab align generic contraints
  • Cleaned up code with csharpier

Should I remove the other random empty lines? ie

  • The gap after the constructor
  • Between partial class Generated and /// <inheritdoc />
  • Between the namespace declartation and the partial class declaration
  • Consider using a file scoped namespace to reduce nesting

@TimothyMakkison TimothyMakkison force-pushed the source_writer_2 branch 2 times, most recently from f9e4fcf to cfdddeb Compare April 4, 2025 21:52
@TimothyMakkison TimothyMakkison marked this pull request as ready for review April 4, 2025 21:55
@TimothyMakkison TimothyMakkison force-pushed the source_writer_2 branch 2 times, most recently from cf7832b to 74b5c74 Compare April 4, 2025 22:26
@codecov
Copy link

codecov bot commented Apr 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.51%. Comparing base (6ebeda5) to head (7758e56).
Report is 180 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1967      +/-   ##
==========================================
- Coverage   87.73%   85.51%   -2.22%     
==========================================
  Files          33       36       +3     
  Lines        2348     2506     +158     
  Branches      294      365      +71     
==========================================
+ Hits         2060     2143      +83     
- Misses        208      285      +77     
+ Partials       80       78       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisPulman ChrisPulman merged commit 2d13fff into reactiveui:main Apr 5, 2025
2 of 3 checks passed
@TimothyMakkison TimothyMakkison mentioned this pull request Apr 18, 2025
Merged
@github-actions
Copy link

github-actions bot commented Apr 20, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ChrisPulman ChrisPulman ChrisPulman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimothyMakkison @ChrisPulman