Internal refactoring to remove internal RequestData and rename internal Request to ClientRequestStream
#481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Nov 29, 2022
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset refactors some internal logic to remove the internal
RequestDataand reuse the request object instead (#480). Additionally, it renames the internal onlyReact\Http\Client\Requestclass toReact\Http\Io\ClientRequestStreamto avoid confusion.This does not affect the public
React\Http\Message\Requestclass or any other public APIs, so this should be safe to apply. The test suite confirms this has 100% code coverage and does not otherwise affect our APIs.Builds on top of #480 and #389
Done in preparation for #468