Incorrect REMSH args when sname is used. #115
Conversation
|
What if someone uses |
|
Usually I configure '-sname' or '-name' only with name part, but I think that could be better to parse the REMSH_NAME and try to find the '@' to compose the correct arguments and use the |
|
That sounds reasonable to me. |
|
What if the remsh node starts in hidden mode ( |
Feel free to use this branch, but make a separate commit because it's not related to |
|
I don't think Relevant info: DragonFlyBSD, FreeBSD, OpenBSD, NetBSD, toybox, BusyBox, OpenSolaris, Mac OS X. |
|
This also applies to OpenSolaris, SmartOS and OmniOS This does work on FreeBSD and OSX. |
|
I've updated the 'Incorrect REMSH' commit, now it tries to guess if hostname returns the fqdn name. If node type is |
Thanks, can you wrap the long error message below 80 chars? Otherwise, this looks like a reasonable fix for the portability issues to me. |
When a node is configured with -sname in app.config or sys.config the REMSH_NAME_ARG and REMSH_REMSH_ARG arguments are incorrect due the assumption that the node name always contains '@'. To fix the bug, the script tries to find '@' and then compose the arguments acording to node name type. If in long name mode the script can't compose a correct node name exits with warning.
To avoid problems with REMSH node being visible from another nodes starts it in hidden mode (erl -hidden).
|
Wrapped !!! Regards. |
|
Thanks. |
|
Just FYI, |
Incorrect REMSH args when sname is used.
When a node is configured with -sname in app.config or sys.config
the REMSH_NAME_ARG and REMSH_REMSH_ARG arguments are incorrect.