Fix: Handle query parameters in m3u8 URL validation #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkonsti
approved these changes
Dec 4, 2024
Member
hkonsti
left a comment
There was a problem hiding this comment.
Thanks for submitting. Makes perfect sense
Member
|
@Yidaotus this is in the 0.10.2 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug in the URL validation logic for m3u8 video sources. Previously, the code checked if the URL ended with ".m3u8" without considering query parameters, which caused valid URLs like /manifest.m3u8?parameter=2 to be incorrectly rejected.