Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: move CLIENT SETINFO commands to connection handshake #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2025
Merged

refactor: move CLIENT SETINFO commands to connection handshake #2033

merged 3 commits into from
Oct 21, 2025

Conversation

@PavelPashov
Copy link
Contributor

@PavelPashov PavelPashov commented Oct 20, 2025 •
edited
Loading

Description

This PR fixes several issues related to the CLIENT SETINFO commands:

  1. 2030 & 2031 When using reconnectOnError in client configurations with Redis servers older than version 7.2.x. In these cases, ioredis attempts to execute the CLIENT SETINFO command, which is not supported in older Redis versions. When combined with reconnectOnError, this results in continuous reconnection attempts. To address this, an IGNORE_RECONNECT_ON_ERROR command flag has been introduced, currently applied only to the CLIENT command.

  2. 2031 When using cluster with autopipelining. The CLIENT command should be included in the notAllowedAutoPipelineCommands

  3. 2025 When using DragonflyDB, now the CLIENT SETINFO commands are issued in the connectHandler instead of the readyHandler

This was referenced Oct 20, 2025
Open
Closed
@PavelPashov PavelPashov force-pushed the refactor/relocate-client-setinfo-commands branch from 02e4a99 to f025d4b Compare October 20, 2025 14:07
@PavelPashov PavelPashov force-pushed the refactor/relocate-client-setinfo-commands branch from dbc7ead to 5c9a2e9 Compare October 21, 2025 10:13
@PavelPashov PavelPashov marked this pull request as ready for review October 21, 2025 12:08
bobymicroby
bobymicroby approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@bobymicroby bobymicroby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PavelPashov PavelPashov force-pushed the refactor/relocate-client-setinfo-commands branch from 0a8ca39 to 721008d Compare October 21, 2025 13:19
@PavelPashov PavelPashov merged commit fcbbbe8 into redis:main Oct 21, 2025
9 checks passed
@PavelPashov PavelPashov deleted the refactor/relocate-client-setinfo-commands branch October 21, 2025 13:24
github-actions bot pushed a commit that referenced this pull request Oct 21, 2025
@ioredis-robot @semantic-release-bot
chore(release): 5.8.2 [skip ci]
d5f5b40 
## [5.8.2](v5.8.1...v5.8.2) (2025-10-21)

### Bug Fixes

* default IP family selection to 0 ([#2028](#2028)) ([fb082d6](fb082d6)), closes [#2026](#2026)
* move CLIENT SETINFO commands to connection handshake ([#2033](#2033)) ([fcbbbe8](fcbbbe8))
@github-actions
Copy link

🎉 This PR is included in version 5.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisbbreuer chrisbbreuer mentioned this pull request Oct 21, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobymicroby bobymicroby bobymicroby approved these changes

@nkaradzhov nkaradzhov nkaradzhov approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PavelPashov @bobymicroby @nkaradzhov