Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ggivo
Copy link
Contributor

@ggivo ggivo commented Sep 2, 2025

Fix race condition in maintenance event rebind completion

Problem

Race condition during MOVING notifications when processed in the same Netty buffer read. The rebind completion check was performed too early, causing timeouts when MOVING notifications and command responses appeared in the same buffer.

Solution

  • Moved rebind state check from beginning to end of decode cycle in CommandHandler
  • Only mark rebind complete when command stack is actually empty after processing
  • Added debug logging for rebind progress tracking

Changes

  • CommandHandler.java: Moved rebindInProgress check to end of decode() method
  • MaintenanceAwareConnectionWatchdog.java: Enhanced logging in address supplier

Impact

Fixes timeouts during endpoint rebind operations on single proxy policy.

Fixes: CAE-1386

Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise - awesome change!

@ggivo ggivo changed the title [maintenace-events] timeouts seen during endpoint re-bind and migrate [Hitless Upgrades] Timeouts seen during endpoint re-bind and migrate Sep 2, 2025
@ggivo ggivo added this to the 7.0.0.RELEASE milestone Sep 2, 2025
@ggivo ggivo added the type: improvement An improvement to the existing implementation label Sep 2, 2025
@ggivo ggivo merged commit 7a22f26 into main Sep 2, 2025
11 of 12 checks passed
@ggivo ggivo deleted the cae-1386 branch September 2, 2025 13:46
@ggivo ggivo added the type: bug A general bug label Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug type: improvement An improvement to the existing implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants