Codecov Report

❌ Patch coverage is 73.55372% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.53%. Comparing base (95e5fb3) to head (f60121e).
⚠️ Report is 6 commits behind head on main.

@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
+ Coverage   48.64%   50.53%   +1.89%     
==========================================
  Files         123      124       +1     
  Lines       14564    14132     -432     
==========================================
+ Hits         7085     7142      +57     
+ Misses       7013     6526     -487     
+ Partials      466      464       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thanks for your contribution! I think it looks quite solid. It was not clear to me what is the schema you are using for the sqs pluging. I guess it would be possible to add some tests to make sure the schema is being correctly parsed

Thank you so much @muhammad-asghar-ali this looks fantastic. I don't have immediate access to an AWS account atm, so it will take me a few days to get around to testing this but we will work to get this in very soon. In the meantime do you mind seeing @avillega's comment above?

Can you also please confirm the intended schema is this?

sqs://<aws-region>/<queue-name>

Thanks for your contribution! I think it looks quite solid. It was not clear to me what is the schema you are using for the sqs pluging. I guess it would be possible to add some tests to make sure the schema is being correctly parsed

Actually now that I look at it, we don't have unit tests for the sender subsystem (where the url parsing occurs). Let me add some for testing parsing of http(s) and poll urls and then you can rebase this PR and plug in additional tests for sqs urls.

@muhammad-asghar-ali if you get a chance take a look at the referenced PR and if you rebase we should be able to add url parsing tests there.

Thanks for review, I'll look into the suggestion.

Thank you so much @muhammad-asghar-ali this looks fantastic. I don't have immediate access to an AWS account atm, so it will take me a few days to get around to testing this but we will work to get this in very soon. In the meantime do you mind seeing @avillega's comment above?

Can you also please confirm the intended schema is this?

sqs://<aws-region>/<queue-name>

sure I'll provide it.. meanwhile I'm working on test-case suggested by @avillega

@avillega @dfarr please review the PR
Thank you

@dfarr Thank you for your suggestions, I really appreciate them and will start working on them as soon as possible.

@dfarr Thank you for your suggestion. I'm still working to understand the broader context and truly appreciate your insight and patience.

@dfarr Thank you for your suggestion. I'm still working to understand the broader context and truly appreciate your insight and patience.

Of course and thank you! If you ever want to jump on a call reach out to me on our discord, more than happy to answer any questions there :)

🎉 Thank you so much @muhammad-asghar-ali !!!

Thank you for the suggestion. I'm looking forward to contributing more and tackling new challenges.