Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change flag to pid and use defaults for pid/ttl #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2025
Merged

Change flag to pid and use defaults for pid/ttl #805

merged 1 commit into from
Sep 14, 2025

Conversation

@dfarr
Copy link
Member

@dfarr dfarr commented Sep 14, 2025

This PR simplifies the task cli experience.

# at minimum
resonate tasks claim --counter 1
resonate tasks heartbeat
resonate tasks complete --counter 1

# optionally
resonate tasks claim --counter 1 --pid foo --ttl 1m
resonate tasks heartbeat --pid foo
resonate tasks complete --counter 1

@codecov
Copy link

codecov bot commented Sep 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.71%. Comparing base (c25f947) to head (c9cdcba).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/tasks/claim.go 0.00% 9 Missing ⚠️
cmd/tasks/heartbeat.go 0.00% 4 Missing ⚠️
cmd/tasks/complete.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
+ Coverage   48.66%   48.71%   +0.04%     
==========================================
  Files         123      123              
  Lines       14564    14559       -5     
==========================================
+ Hits         7088     7092       +4     
+ Misses       7010     7002       -8     
+ Partials      466      465       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dfarr dfarr requested a review from avillega September 14, 2025 17:53
@dfarr dfarr merged commit 436edf7 into main Sep 14, 2025
6 of 7 checks passed
@dfarr dfarr deleted the feature/task-cli-defaults branch September 26, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tomperez98 Tomperez98 Tomperez98 approved these changes

@avillega avillega Awaiting requested review from avillega

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dfarr @Tomperez98