Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add fencing token #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 18, 2025
Merged

Add fencing token #813

merged 10 commits into from
Sep 18, 2025

Conversation

@avillega
Copy link
Member

No description provided.

@avillega avillega requested a review from dfarr September 17, 2025 01:07
@avillega
Copy link
Member Author

I think this is almost completed, the hardest part is testing, but we can get the review started.

avillega
avillega commented Sep 17, 2025
View reviewed changes
cmd/serve/serve.go
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was unformatted, this changes are format only

@codecov
Copy link

codecov bot commented Sep 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 44.93243% with 163 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.55%. Comparing base (6b5ade4) to head (38cdc91).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/serve/serve.go 0.00% 110 Missing ⚠️
internal/app/subsystems/api/http/promise.go 25.00% 15 Missing and 3 partials ⚠️
internal/app/coroutines/completePromise.go 40.00% 4 Missing and 2 partials ⚠️
internal/app/coroutines/createCallback.go 25.00% 4 Missing and 2 partials ⚠️
internal/app/coroutines/createPromise.go 57.14% 4 Missing and 2 partials ⚠️
...rnal/app/subsystems/aio/store/postgres/postgres.go 90.00% 4 Missing and 2 partials ⚠️
internal/app/subsystems/aio/store/sqlite/sqlite.go 90.00% 4 Missing and 2 partials ⚠️
internal/kernel/t_api/status.go 0.00% 2 Missing ⚠️
internal/app/coroutines/searchPromises.go 0.00% 1 Missing ⚠️
internal/app/coroutines/timeoutPromises.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
+ Coverage   50.18%   50.55%   +0.36%     
==========================================
  Files         123      124       +1     
  Lines       14011    14237     +226     
==========================================
+ Hits         7032     7197     +165     
- Misses       6518     6563      +45     
- Partials      461      477      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dfarr
dfarr requested changes Sep 17, 2025
View reviewed changes
Copy link
Member

@dfarr dfarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks seriously GREAT! My requests are mostly in regards to the way we communicate this error.

@avillega avillega requested a review from dfarr September 17, 2025 23:22
dfarr
dfarr approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@dfarr dfarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Let's get this in and do a release tomorrow :)

avillega
avillega commented Sep 18, 2025
View reviewed changes
@avillega avillega merged commit d3ea880 into main Sep 18, 2025
6 of 7 checks passed
@avillega avillega deleted the fencing-task branch September 18, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfarr dfarr dfarr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avillega @dfarr