Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@muhammad-asghar-ali
Copy link
Contributor

@muhammad-asghar-ali muhammad-asghar-ali commented Oct 4, 2025

  • Improved naming consistency
  • Fixed typos and enhanced variable naming for better code readability and maintainability
  • Aligned SQS plugin naming conventions with Go standards and other plugins in the codebase

@codecov
Copy link

codecov bot commented Oct 4, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.05%. Comparing base (8a0f652) to head (83d90ab).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/plugins/sqs/sqs.go 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
- Coverage   50.07%   50.05%   -0.03%     
==========================================
  Files         126      126              
  Lines       14420    14434      +14     
==========================================
+ Hits         7221     7225       +4     
- Misses       6718     6726       +8     
- Partials      481      483       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dfarr
Copy link
Member

dfarr commented Oct 13, 2025

Thanks @muhammad-asghar-ali! Do you mind undoing the changes that convert names from camel case to snake case? We use camel case pretty consistently so it would be nice to stick with that.

@muhammad-asghar-ali
Copy link
Contributor Author

Thanks @muhammad-asghar-ali! Do you mind undoing the changes that convert names from camel case to snake case? We use camel case pretty consistently so it would be nice to stick with that.

Sure I'll do it... but I convert it b/c in go there is common approach to use snake_case naming instead of camelCase...

@dfarr
Copy link
Member

dfarr commented Oct 14, 2025

Sure I'll do it... but I convert it b/c in go there is common approach to use snake_case naming instead of camelCase...

I was curious so I looked it up, it looks like go recommends MixedCaps.

@muhammad-asghar-ali
Copy link
Contributor Author

muhammad-asghar-ali commented Oct 14, 2025

Sure I'll do it... but I convert it b/c in go there is common approach to use snake_case naming instead of camelCase...

I was curious so I looked it up, it looks like go recommends MixedCaps.

It's my personal observation that mostly go projects use the single word or snake_case variable naming. So finally the recommended way is MixedCaps, thanks for sharing... 😊

I'll revert the code as soon as possible

@muhammad-asghar-ali
Copy link
Contributor Author

@dfarr changes done please check

@dfarr dfarr merged commit 6bfe517 into resonatehq:main Oct 16, 2025
7 checks passed
@dfarr
Copy link
Member

dfarr commented Oct 16, 2025

Thank once again @muhammad-asghar-ali !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants