-
Couldn't load subscription status.
- Fork 39
chore(plugin): correct typo for sqs package #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(plugin): correct typo for sqs package #847
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 50.07% 50.05% -0.03%
==========================================
Files 126 126
Lines 14420 14434 +14
==========================================
+ Hits 7221 7225 +4
- Misses 6718 6726 +8
- Partials 481 483 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @muhammad-asghar-ali! Do you mind undoing the changes that convert names from camel case to snake case? We use camel case pretty consistently so it would be nice to stick with that. |
Sure I'll do it... but I convert it b/c in go there is common approach to use snake_case naming instead of camelCase... |
I was curious so I looked it up, it looks like go recommends MixedCaps. |
It's my personal observation that mostly go projects use the single word or snake_case variable naming. So finally the recommended way is MixedCaps, thanks for sharing... 😊 I'll revert the code as soon as possible |
|
@dfarr changes done please check |
|
Thank once again @muhammad-asghar-ali !!! |
Uh oh!
There was an error while loading. Please reload this page.