Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: allow basic auth header overwrites #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wei merged 1 commit into from
May 5, 2020
Merged

fix: allow basic auth header overwrites #21

wei merged 1 commit into from
May 5, 2020

Conversation

@wei
Copy link
Member

@wei wei commented Apr 29, 2020 •
edited
Loading

GitHub Checkout Action automatically set basic auth header overwriting access tokens supplied in HTTPS clone urls.

# .git/config

[core]
	repositoryformatversion = 0
	filemode = true
	bare = false
	logallrefupdates = true
[remote "origin"]
	url = https://github.com/repo-sync/private-destination-repo
	fetch = +refs/heads/*:refs/remotes/origin/*
[gc]
	auto = 0
[http "https://github.com/"]
	extraheader = AUTHORIZATION: basic ***
[branch "master"]
	remote = origin
	merge = refs/heads/master

This PR uses git command to delete these two lines:

[http "https://github.com/"]
	extraheader = AUTHORIZATION: basic ***

Fix #18

We can test the fix with repo-sync/github-sync@fix-private-source-with-pat

@wei
fix: allow basic auth header overwrites
960980c 
GitHub Actions automatically set basic auth header overwriting access tokens supplied in HTTPS clone urls.

Fix #18
@wei wei added the bug Something isn't working label Apr 29, 2020
@wei wei requested a review from zeke April 29, 2020 01:43
@wei wei self-assigned this Apr 29, 2020
@wei wei mentioned this pull request Apr 29, 2020
Closed
@wei wei merged commit bda9932 into master May 5, 2020
@zeke
Copy link
Contributor

zeke commented May 5, 2020

☝️ @wei please leave this branch around for a bit if you don't mind. Our app is frozen for the week of GitHub Satellite so we won't be able to switch over to @v2 until next week.

@wei
Copy link
Member Author

wei commented May 5, 2020

☝️ @wei please leave this branch around for a bit if you don't mind. Our app is frozen for the week of GitHub Satellite so we won't be able to switch over to @v2 until next week.

Ok sounds good!

wei added a commit that referenced this pull request Aug 25, 2020
@wei
fix: unset default basic auth header if set
5e86432 
relates to #21
@wei wei mentioned this pull request Aug 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeke zeke Awaiting requested review from zeke

Assignees

@wei wei

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fatal: repository not found

3 participants

@wei @zeke