style(select): harmonise scrollHeights for selects #723
Conversation
6a0ec04 to
0925c5c
Compare
There was a problem hiding this comment.
Centralize the height in the config.ts file in the utils folder
export const CONFIG = {
MESSAGE_LIFE: 5000, // Message lifetime in ms
SELECT_SCROLL_HEIGHT: '50vh'
}
And use this in the various components. This allows you to change the value all at once, should you wish to modify it later.
0925c5c to
8ebffde
Compare
| import { MultiSelectModule as PrimeNgMultiSelectModule } from 'primeng/multiselect'; | ||
| import { map, merge, Observable, Subscription, switchMap, tap } from 'rxjs'; | ||
| import { TranslateLabelService } from '../services/translate-label.service'; | ||
| import { CONFIG } from '../../../../../utils/config'; |
There was a problem hiding this comment.
Since it's a module, I think it would be better to inject the config via the configuration and not via an import. This would create an external dependency.
Then, you can use inject in the component.
https://medium.com/ngconf/configure-your-angular-apps-with-an-injection-token-be16eee59c40
There was a problem hiding this comment.
I read the article, but I'm still not sure what this means, and I have no clue how to implement. 😅
There was a problem hiding this comment.
You can leave it like that, and we'll see how to change things next time we refactor.
| import { map, merge, Observable, Subject, switchMap } from 'rxjs'; | ||
| import { IQuery, IQueryOptions, IRemoteAutoCompleteFilter, IValueSelect } from './remote-autocomplete.interface'; | ||
| import { RemoteAutocompleteService } from './remote-autocomplete.service'; | ||
| import { CONFIG } from '../../../../../utils/config'; |
| import { SelectModule } from 'primeng/select'; | ||
| import { map, merge, Observable, Subscription, switchMap, tap } from 'rxjs'; | ||
| import { TranslateLabelService } from '../services/translate-label.service'; | ||
| import { CONFIG } from '../../../../../utils/config'; |
| import { TreeSelectModule } from 'primeng/treeselect'; | ||
| import { map, merge, Observable, Subscription, switchMap, tap } from 'rxjs'; | ||
| import { TranslateLabelService } from '../services/translate-label.service'; | ||
| import { CONFIG } from '../../../../../utils/config'; |
2b8fccc to
7f9437e
Compare
Co-Authored-by: Pascal Repond <[email protected]>
7f9437e to
89ec1f7
Compare
No description provided.