Thanks to visit codestin.com
Credit goes to github.com

Skip to content

library: improve library detail view and exception dates management #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2022
Merged

library: improve library detail view and exception dates management #799

merged 1 commit into from
Feb 1, 2022

Conversation

@zannkukai
Copy link
Contributor

Co-Authored-by: Renaud Michotte [email protected]

How to test?

image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai added this to the v1.9.0 milestone Jan 27, 2022
@zannkukai zannkukai self-assigned this Jan 27, 2022
@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: user management labels Jan 27, 2022
@zannkukai zannkukai force-pushed the zan-fix-library-exceptions branch from 0d04079 to 60fb933 Compare January 27, 2022 15:13
@zannkukai zannkukai requested review from Garfield-fr and jma January 27, 2022 15:14
@github-actions github-actions bot removed f: public ui Public interface, as opposed to the professional interface f: circulation Concerns the circulation interface or backend f: user management labels Jan 27, 2022
jma
jma approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, this seems not so easy.

@zannkukai zannkukai force-pushed the zan-fix-library-exceptions branch from 60fb933 to ecc65f4 Compare February 1, 2022 09:57
@zannkukai
library: improve library detail view.
66444e6 
* Improves the library detail view, opening hours and exception dates.
* Filters exception dates, keeping only useful exceptions (view + forms).
* Closes rero/rero-ils#1782.
* Closes rero/rero-ils#1690.
* Closes rero/rero-ils#2577.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai force-pushed the zan-fix-library-exceptions branch from ecc65f4 to 66444e6 Compare February 1, 2022 13:16
@zannkukai zannkukai merged commit e21a8b0 into rero:staging Feb 1, 2022
@zannkukai zannkukai deleted the zan-fix-library-exceptions branch February 1, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@jma jma jma approved these changes

@benerken benerken benerken approved these changes

Assignees

@zannkukai zannkukai

Labels

f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface

Projects

None yet

Milestone

v1.9.0

4 participants

@zannkukai @Garfield-fr @jma @benerken