Thanks to visit codestin.com
Credit goes to github.com

Skip to content

documents: replace identifiedBy subjects with $ref #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2021
Merged

documents: replace identifiedBy subjects with $ref #2558

merged 1 commit into from
Dec 15, 2021

Conversation

@rerowep
Copy link
Contributor

@rerowep rerowep commented Nov 25, 2021

  • Implements ABC class for identifiedBy replacement.
  • Rewrites contribution identifiedBy replacement.
  • Implements identifiedBy subjects replacement for the types bf:Person and bf:Organisation

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Nov 25, 2021
@rerowep rerowep changed the title documents: repplace identifiedBy subjects with $ref documents: replace identifiedBy subjects with $ref Nov 26, 2021
@rerowep rerowep force-pushed the wep-#2358-contribution-subjects-updates branch 7 times, most recently from 771143c to 254d61a Compare November 27, 2021 17:40
@rerowep rerowep marked this pull request as ready for review November 27, 2021 19:07
zannkukai
zannkukai reviewed Nov 29, 2021
View reviewed changes
@rerowep rerowep force-pushed the wep-#2358-contribution-subjects-updates branch from 254d61a to 335dde5 Compare November 29, 2021 14:29
@rerowep rerowep force-pushed the wep-#2358-contribution-subjects-updates branch from 335dde5 to 507441f Compare December 1, 2021 08:15
@rerowep rerowep force-pushed the wep-#2358-contribution-subjects-updates branch 3 times, most recently from 0b949d7 to 463af36 Compare December 1, 2021 13:37
@rerowep
documents: repplace identifiedBy subjects with $ref
f200140 
* Implements ABC class for identifiedBy replacement.
* Rewrites contribution identifiedBy replacement.
* Implements identifiedBy subjects replacement for the types `bf:Person` and `bf:Organisation`

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#2358-contribution-subjects-updates branch from 463af36 to f200140 Compare December 2, 2021 08:10
@rerowep rerowep added this to the v1.8.0 milestone Dec 9, 2021
@rerowep rerowep merged commit fa8d6b1 into rero:staging Dec 15, 2021
@rerowep rerowep deleted the wep-#2358-contribution-subjects-updates branch December 21, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lauren-d lauren-d lauren-d approved these changes

+3 more reviewers

@zannkukai zannkukai zannkukai approved these changes

@BadrAly BadrAly BadrAly approved these changes

@vgranata vgranata vgranata approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rerowep rerowep

Labels

None yet

Projects

None yet

Milestone

v1.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@rerowep @zannkukai @BadrAly @lauren-d @vgranata