Thanks to visit codestin.com
Credit goes to github.com

Skip to content

dependencies: fix #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2022
Merged

dependencies: fix #2711

merged 1 commit into from
Feb 21, 2022

Conversation

@rerowep
Copy link
Contributor

@rerowep rerowep commented Feb 17, 2022

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Feb 17, 2022
lauren-d
lauren-d approved these changes Feb 17, 2022
View reviewed changes
jma
jma approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the commit message into: dependencies: fix tests

@rerowep rerowep force-pushed the wep-fix-dependencies branch 2 times, most recently from 7f364b5 to 100a065 Compare February 21, 2022 12:30
@rerowep
dependencies: fix
3188aa6 
Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-fix-dependencies branch from 100a065 to 3188aa6 Compare February 21, 2022 12:50
@jma jma merged commit e8568e9 into rero:staging Feb 21, 2022
@rerowep rerowep deleted the wep-fix-dependencies branch February 21, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jma jma jma approved these changes

@lauren-d lauren-d lauren-d approved these changes

@zannkukai zannkukai Awaiting requested review from zannkukai

@PascalRepond PascalRepond Awaiting requested review from PascalRepond

Assignees

@rerowep rerowep

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rerowep @jma @lauren-d