Thanks to visit codestin.com
Credit goes to github.com

Skip to content

python: use poetry >= 1.1 #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

python: use poetry >= 1.1 #2720

merged 1 commit into from
Apr 25, 2022

Conversation

@rerowep
Copy link
Contributor

@rerowep rerowep commented Feb 22, 2022

  • Uses poetry >= 1.1.
  • Uses latest invenio packages.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added developers From a developer point of view. documentation labels Feb 22, 2022
@rerowep rerowep self-assigned this Feb 22, 2022
@rerowep rerowep force-pushed the wep-poetry branch 5 times, most recently from eca2938 to 5273ea2 Compare February 22, 2022 19:16
@rerowep rerowep force-pushed the wep-poetry branch 6 times, most recently from 4d1a6a6 to c61414b Compare February 23, 2022 09:04
@github-actions github-actions bot added the dev: documentation About changelog, release notes, installation procedures, gh templates... label Mar 3, 2022
@rerowep rerowep force-pushed the wep-poetry branch 5 times, most recently from 64ab8e4 to 852aecd Compare March 5, 2022 09:47
@rerowep rerowep force-pushed the wep-poetry branch 5 times, most recently from a363e7d to a6ed667 Compare March 21, 2022 20:48
Garfield-fr
Garfield-fr approved these changes Mar 23, 2022
View reviewed changes
PascalRepond
PascalRepond approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@PascalRepond PascalRepond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ubunutu 20.04 (WSL2)/Python 3.9.7

  • uses Poetry 1.1.13 (run poetry self update if needed)
  • removed directory rero_ils.egg-info
  • ran poetry run ./scripts/bootstrap
  • ran poetry run ./scripts/setup -C
  • ran poetry run poe server

Everything OK.
Also need to update this file with commands for documentation : https://github.com/rero/developer-resources/blob/master/rero-instances/rero-ils/dev_installation.md

lauren-d
lauren-d approved these changes Mar 23, 2022
View reviewed changes
@rerowep rerowep force-pushed the wep-poetry branch 2 times, most recently from e1ed5d3 to ad759f0 Compare March 27, 2022 18:03
@jma jma removed their request for review March 28, 2022 06:17
@rerowep rerowep force-pushed the wep-poetry branch 2 times, most recently from 98eea2c to 46d1ca6 Compare March 28, 2022 12:28
@rerowep rerowep force-pushed the wep-poetry branch 3 times, most recently from 7099bc2 to 961fdb1 Compare April 12, 2022 07:56
@rerowep rerowep force-pushed the wep-poetry branch 2 times, most recently from 4f5579e to 7f32080 Compare April 14, 2022 08:23
@rerowep
python: use poetry
765e8ca 
* Uses poetry >= 1.1.
* Uses latest invenio packages.

Poetry should be at latest version for deployment. For example `poetry self update`.
The directory `rero_ils.egg-info` should be removed `rm -rf rero_ils.egg-info` and
the virtual envirement should be deleted `rm -rf $(poetry env info --path)`.

* Changes `replace-idby-subjects` task schedule to 21:22.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep merged commit 6e471a3 into rero:staging Apr 25, 2022
@rerowep rerowep deleted the wep-poetry branch April 25, 2022 11:45
@PascalRepond PascalRepond changed the title python: use poetry python: use poetry >= 1.1 May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@benerken benerken benerken approved these changes

@lauren-d lauren-d lauren-d approved these changes

@PascalRepond PascalRepond PascalRepond approved these changes

+1 more reviewer

@zannkukai zannkukai zannkukai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rerowep rerowep

Labels

dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed dev: documentation About changelog, release notes, installation procedures, gh templates... developers From a developer point of view. f: acquisitions Related to the acquisition module f: circulation Concerns the circulation interface or backend translations Translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rerowep @Garfield-fr @zannkukai @benerken @lauren-d @PascalRepond