oauth: make some information optional #2757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1e3e76 to
f0d623d
Compare
rerowep
reviewed
Mar 10, 2022
rero_ils/modules/patrons/views.py
Outdated
| data['patron_types'] = patron_types | ||
| info = {} | ||
| if patron.get('patron', {}).get('type', {}).get('code'): | ||
| info['patron_type'] = patron['patron']['type']['code'] |
There was a problem hiding this comment.
Some times I prefer to write:
patron_type = patron.get('patron', {}).get('type', {}).get('code')
if patron_type:
info['patron_type'] = patron_type
One line more but more understandable.
lauren-d
approved these changes
Mar 10, 2022
f0d623d to
74bcc36
Compare
* Fixes patron information REST view crash when the patron type code is not present. * Protects the patron information using the oauth permision. Co-Authored-by: Johnny Mariéthoz <[email protected]>
74bcc36 to
953006e
Compare
Garfield-fr
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not present.
Co-Authored-by: Johnny Mariéthoz [email protected]
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list