Thanks to visit codestin.com
Credit goes to github.com

Skip to content

operation log: fix document title for loan #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

operation log: fix document title for loan #2788

merged 1 commit into from
Mar 30, 2022

Conversation

@lauren-d
Copy link
Contributor

@lauren-d lauren-d commented Mar 29, 2022 •
edited
Loading

Co-Authored-by: Lauren-D [email protected]

Why are you opening this PR?

When we do a checkout (or checkin) of a document which de first title isn't a main title, operation logs on loan failed.

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@lauren-d lauren-d self-assigned this Mar 29, 2022
@github-actions github-actions bot added f: activity-logs Everything around logging user or system activities f: circulation Concerns the circulation interface or backend labels Mar 29, 2022
@lauren-d lauren-d added the bug Breaks something but is not blocking label Mar 29, 2022
@lauren-d
operation log: fix document title for loan
bbef14e 
* Uses filter to retrieve main title of the document.
* Closes rero#2581.

Co-Authored-by: Lauren-D <[email protected]>
zannkukai
zannkukai reviewed Mar 30, 2022
View reviewed changes
Copy link
Contributor

@zannkukai zannkukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that any documents required a 'bf:Title' title ? If not, an internal error will occured.

@lauren-d
Copy link
Contributor Author

lauren-d commented Mar 30, 2022 •
edited
Loading

Is that any documents required a 'bf:Title' title ? If not, an internal error will occured.

yes, at least one bf:titletype is required:

rero-ils/rero_ils/modules/documents/jsonschemas/documents/document_title-v0.0.1.json

Line 119 in 8644a31

"form": {

@lauren-d lauren-d requested a review from zannkukai March 30, 2022 08:24
@lauren-d lauren-d merged commit 9990793 into rero:staging Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benerken benerken Awaiting requested review from benerken

@rerowep rerowep Awaiting requested review from rerowep

@vgranata vgranata Awaiting requested review from vgranata

2 more reviewers

@zannkukai zannkukai zannkukai approved these changes

@BadrAly BadrAly BadrAly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lauren-d lauren-d

Labels

bug Breaks something but is not blocking f: activity-logs Everything around logging user or system activities f: circulation Concerns the circulation interface or backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The first document title should be of type bf:Title

3 participants

@lauren-d @zannkukai @BadrAly