document: fix thumbnail caption #2844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the document detailed view, the figure caption behind the thumbnail was vertically displayed. The reason was that the `document_types` jinja filter return only a string (splitted on list of char) instead of a list of string. Co-Authored-by: Renaud Michotte <[email protected]>
lauren-d
approved these changes
Apr 21, 2022
rerowep
approved these changes
Apr 25, 2022
Garfield-fr
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the document detailed view, the figure caption behind the thumbnail
was vertically displayed. The reason was that the
document_typesjinjafilter return only a string (splitted on list of char) instead of a list
of string.
Co-Authored-by: Renaud Michotte [email protected]
How to test?
Before
After
Code review check list