Thanks to visit codestin.com
Credit goes to github.com

Skip to content

alembic: reindex holdings items_count and public_items_count #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2022
Merged

alembic: reindex holdings items_count and public_items_count #2840

merged 1 commit into from
Apr 13, 2022

Conversation

@rerowep
Copy link
Contributor

@rerowep rerowep commented Apr 12, 2022

  • Uses Holding reindex to correct holdings items_count and public_items_count.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Apr 12, 2022
@rerowep rerowep force-pushed the wep-fix-alembic-05555c03fe49 branch 7 times, most recently from 6297584 to 8ee0f40 Compare April 13, 2022 08:50
@rerowep
alembic: fix 05555c03fe49
3aef30d 
* Uses Holding reindex to correct holdings items_count and public_items_count.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-fix-alembic-05555c03fe49 branch from 8ee0f40 to 3aef30d Compare April 13, 2022 09:02
@rerowep rerowep merged commit c99c1ef into rero:staging Apr 13, 2022
@PascalRepond PascalRepond added the correction An implemented feature doesn't work as expected. label Apr 14, 2022
@rerowep rerowep deleted the wep-fix-alembic-05555c03fe49 branch May 4, 2022 21:10
@PascalRepond PascalRepond changed the title alembic: fix 05555c03fe49 alembic: reindex holdings items_count and public_items_count May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@benerken benerken benerken approved these changes

@lauren-d lauren-d lauren-d approved these changes

@PascalRepond PascalRepond PascalRepond approved these changes

+2 more reviewers

@zannkukai zannkukai zannkukai approved these changes

@vgranata vgranata vgranata approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rerowep rerowep

Labels

correction An implemented feature doesn't work as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rerowep @Garfield-fr @zannkukai @benerken @lauren-d @vgranata @PascalRepond