Thanks to visit codestin.com
Credit goes to github.com

Skip to content

contribution: fix replace ReplaceMefIdentifiedBy #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2022
Merged

contribution: fix replace ReplaceMefIdentifiedBy #2856

merged 1 commit into from
May 9, 2022

Conversation

@rerowep
Copy link
Contributor

@rerowep rerowep commented Apr 26, 2022

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Apr 26, 2022
@rerowep rerowep force-pushed the wep-fix-replace-identified_by branch from dffdb79 to 1742dac Compare April 28, 2022 14:04
@rerowep rerowep marked this pull request as ready for review May 2, 2022 06:29
@rerowep rerowep force-pushed the wep-fix-replace-identified_by branch from 1742dac to 20ffd7b Compare May 2, 2022 06:32
@rerowep rerowep force-pushed the wep-fix-replace-identified_by branch 7 times, most recently from b11ae61 to eef0b4e Compare May 5, 2022 08:30
@rerowep
contribution: fix replace ReplaceMefIdentifiedBy
29c7442 
* Adds replacment implementation for `subjects_imported`.
* Displays deleted contributions.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-fix-replace-identified_by branch from eef0b4e to 29c7442 Compare May 5, 2022 13:16
@rerowep rerowep merged commit 6b05336 into rero:staging May 9, 2022
@rerowep rerowep deleted the wep-fix-replace-identified_by branch May 9, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@vgranata vgranata Awaiting requested review from vgranata

+2 more reviewers

@zannkukai zannkukai zannkukai approved these changes

@BadrAly BadrAly BadrAly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rerowep rerowep

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rerowep @Garfield-fr @zannkukai @BadrAly