Thanks to visit codestin.com
Credit goes to github.com

Skip to content

dojson: fix rero 260 #2944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2022
Merged

dojson: fix rero 260 #2944

merged 1 commit into from
Jun 22, 2022

Conversation

@rerowep
Copy link
Contributor

@rerowep rerowep commented Jun 7, 2022

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

@rerowep rerowep self-assigned this Jun 7, 2022
@github-actions github-actions bot added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Jun 7, 2022
@rerowep rerowep force-pushed the wep-fix-dojson-rero-260 branch 7 times, most recently from 2971480 to 16e2fc6 Compare June 13, 2022 21:19
@rerowep rerowep force-pushed the wep-fix-dojson-rero-260 branch 2 times, most recently from 2d63fd1 to 213e9d9 Compare June 15, 2022 21:02
@rerowep rerowep marked this pull request as ready for review June 20, 2022 08:11
@rerowep rerowep requested review from BadrAly, benerken and lauren-d June 20, 2022 08:11
@rerowep
dojson: fix rero 260
bff86d0 
Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-fix-dojson-rero-260 branch from 213e9d9 to bff86d0 Compare June 21, 2022 07:52
@rerowep rerowep merged commit 8390140 into rero:staging Jun 22, 2022
@rerowep rerowep deleted the wep-fix-dojson-rero-260 branch June 22, 2022 08:43
@PascalRepond PascalRepond added the correction An implemented feature doesn't work as expected. label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benerken benerken benerken approved these changes

@lauren-d lauren-d Awaiting requested review from lauren-d

+2 more reviewers

@zannkukai zannkukai zannkukai approved these changes

@BadrAly BadrAly BadrAly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rerowep rerowep

Labels

correction An implemented feature doesn't work as expected. f: data About data model, importation, transformation, exportation of data, specific for bibliographic data

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rerowep @zannkukai @benerken @BadrAly @PascalRepond