Thanks to visit codestin.com
Credit goes to github.com

Skip to content

documents: fix facets subject and genre form #3099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2022
Merged

documents: fix facets subject and genre form #3099

merged 1 commit into from
Sep 21, 2022

Conversation

@vgranata
Copy link
Contributor

@vgranata vgranata commented Sep 19, 2022 •
edited by jma
Loading

  • Adds filters also if no facet list are specified in the URL.
  • Uses Q() instead of query for facet filters.
  • Adds support for facet filter configuration.
  • Removed hard coded facet filter (subjects).

Co-Authored-by: Valeria Granata [email protected]
Co-Authored-by: Johnny Mariéthoz [email protected]

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

@jma jma force-pushed the fix-facets-subjects-genreform branch from 4b6b0fd to f5aa9e6 Compare September 20, 2022 06:42
@jma jma marked this pull request as ready for review September 20, 2022 09:24
@jma jma requested review from rerowep and zannkukai September 20, 2022 09:24
@jma jma changed the title documents: fix facets Subject fiction, no fiction and facet Genre, form documents: fix facets subject and genre form Sep 20, 2022
zannkukai
zannkukai reviewed Sep 20, 2022
View reviewed changes
Garfield-fr
Garfield-fr approved these changes Sep 20, 2022
View reviewed changes
@PascalRepond PascalRepond force-pushed the fix-facets-subjects-genreform branch 3 times, most recently from 8cab9a3 to fa5d803 Compare September 20, 2022 12:51
@PascalRepond PascalRepond requested a review from jma September 20, 2022 12:52
@PascalRepond PascalRepond force-pushed the fix-facets-subjects-genreform branch from fa5d803 to f9908ec Compare September 20, 2022 12:55
zannkukai
zannkukai reviewed Sep 20, 2022
View reviewed changes
@PascalRepond PascalRepond force-pushed the fix-facets-subjects-genreform branch from f9908ec to 498dfc3 Compare September 20, 2022 14:55
@jma jma force-pushed the fix-facets-subjects-genreform branch 4 times, most recently from 3d11e16 to bba385e Compare September 21, 2022 09:07
@jma jma force-pushed the fix-facets-subjects-genreform branch 2 times, most recently from 005bfea to e8eebfe Compare September 21, 2022 09:57
rerowep
rerowep reviewed Sep 21, 2022
View reviewed changes
zannkukai
zannkukai approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@zannkukai zannkukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for this job !

@pronguen
Copy link
Contributor

pronguen commented Sep 21, 2022 •
edited
Loading

  • NPR/21.09: Facets "Subject (fiction)" and "Subject (non-fiction)" are not working correctly
    • Specified was: AND
    • OR is applied when selecting 2 values of the facet
    • Displayed occurrences next to facet value are calculated according to AND operator
    • NPR/21.09: tested ok

@vgranata @jma
documents: fix facets subject and genre form
352bcb1 
* Adds filters also if no facet list are specified in the URL.
* Uses `Q()` instead of query for facet filters.
* Adds support for facet filter configuration.
* Removed hard coded facet filter (subjects).

Co-Authored-by: Valeria Granata <[email protected]>
Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the fix-facets-subjects-genreform branch from e8eebfe to 352bcb1 Compare September 21, 2022 14:27
@rerowep rerowep self-requested a review September 21, 2022 18:02
@lauren-d lauren-d merged commit 299b2ce into rero:staging Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benerken benerken benerken approved these changes

@rerowep rerowep rerowep approved these changes

@jma jma Awaiting requested review from jma

@lauren-d lauren-d Awaiting requested review from lauren-d

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

+2 more reviewers

@pronguen pronguen pronguen left review comments

@zannkukai zannkukai zannkukai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vgranata @pronguen @Garfield-fr @zannkukai @benerken @rerowep @lauren-d