Thanks to visit codestin.com
Credit goes to github.com

Skip to content

security: enhance login #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

security: enhance login #3223

merged 1 commit into from
Feb 6, 2023

Conversation

@Garfield-fr
Copy link
Contributor

  • Adds password generator and validator.
  • Adds entrypoint to generate a new password.
  • Adds entrypoint to validate a password.
  • Updates users api to use the new password generator and validator.
  • Updates users fixtures to add the password field.
  • Adds beautifulsoup4 package for test.
  • Disables account rest api endpoint.
  • Adds validations on the change password api.
  • Updates password on the interface test information.
  • Adds the possibility to put a message in the cache and display it on the html page.
  • Changes of the API response on invalid login.

Co-Authored-by: Bertrand Zuchuat [email protected]

@github-actions github-actions bot added dev: fixtures Fixtures data used for ils.test and ilsdev.test f: data migration Data migration from a legacy system or a previous version f: user management labels Jan 26, 2023
@Garfield-fr Garfield-fr self-assigned this Jan 26, 2023
@PascalRepond
Copy link
Contributor

PascalRepond commented Feb 2, 2023 •
edited by Garfield-fr
Loading

PO tests

  • REP: [Not-blocking] in the professional ui, user editor, when generating a password, it should be shown by default.
  • REP: When trying to login with an email or username that doesn't exist, the HTTP response still contains the error field email. Response is OK with incorrect password.

@Garfield-fr
Copy link
Contributor Author

  • REP: [Not-blocking] in the professional ui, user editor, when generating a password, it should be shown by default.

The password should not be displayed by default, as this presents a security hole. Moreover, it is copied to the clipboard.

@Garfield-fr Garfield-fr force-pushed the US-Access branch 3 times, most recently from 18928b6 to 7501f07 Compare February 6, 2023 09:31
@Garfield-fr
security: enhance login
09cecfa 
* Adds password generator and validator.
* Adds entrypoint to generate a new password.
* Adds entrypoint to validate a password.
* Updates users api to use the new password generator and validator.
* Updates users fixtures to add the password field.
* Adds beautifulsoup4 package for test.
* Disables account rest api endpoint.
* Adds validations on the change password api.
* Updates password on the interface test information.
* Adds the possibility to put a message in the cache
  and display it on the html page.
* Changes of the API response on invalid login.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr merged commit 4997a1c into staging Feb 6, 2023
@Garfield-fr Garfield-fr deleted the US-Access branch February 6, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jma jma jma approved these changes

@lauren-d lauren-d lauren-d approved these changes

@PascalRepond PascalRepond PascalRepond approved these changes

@zannkukai zannkukai Awaiting requested review from zannkukai

Assignees

@Garfield-fr Garfield-fr

Labels

dev: fixtures Fixtures data used for ils.test and ilsdev.test f: data migration Data migration from a legacy system or a previous version f: user management

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Garfield-fr @PascalRepond @jma @lauren-d