billing stats: process only validated ill_requests #3381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmo
requested changes
Jun 21, 2023
zannkukai
approved these changes
Jun 22, 2023
- Fixes ill request stats processing for billing so only validated ill requests are counted. - The stats collector counts all ill_requests that were created or updated. - If a request changes to `validated` multiple times it will be counted multiple times. - Adds no unit tests; they will be added later for the full module. - Closes rero#3359. Co-Authored-by: Pascal Repond <[email protected]>
5becb90 to
af1d333
Compare
jma
approved these changes
Jun 27, 2023
PascalRepond
added a commit
to PascalRepond/rero-ils
that referenced
this pull request
Jun 30, 2023
- Fixes pycodestyle error because Github Actions test were not rolled on PR rero#3381 latest push. Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond
added a commit
to PascalRepond/rero-ils
that referenced
this pull request
Jul 3, 2023
- Fixes pycodestyle error because Github Actions test were not rolled on PR rero#3381 latest push. - Fixes safety errors for July 2023. Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond
added a commit
to PascalRepond/rero-ils
that referenced
this pull request
Jul 3, 2023
- Updates dependencies. - Fixes pycodestyle error because Github Actions test were not rolled on PR rero#3381 latest push. - Fixes safety errors for July 2023. Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond
added a commit
to PascalRepond/rero-ils
that referenced
this pull request
Jul 3, 2023
- Fixes pycodestyle error because Github Actions test were not rolled on PR rero#3381 latest push. - Fixes safety errors for July 2023. Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond
added a commit
to PascalRepond/rero-ils
that referenced
this pull request
Jul 3, 2023
- Fix safety checks for July 2023. - Fixes pycodestyle error because Github Actions test were not rolled on PR rero#3381 latest push. Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond
added a commit
to PascalRepond/rero-ils
that referenced
this pull request
Jul 3, 2023
- Fix safety checks for July 2023. - Fixes pycodestyle error because Github Actions test were not rolled on PR rero#3381 latest push. Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond
added a commit
that referenced
this pull request
Jul 3, 2023
- Fix safety checks for July 2023. - Fixes pycodestyle error because Github Actions test were not rolled on PR #3381 latest push. Co-Authored-by: Pascal Repond <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validatedmultiple times it will be counted multiple times.denied#3359.Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?