import: fix SLSP #3751
Merged
import: fix SLSP #3751
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rerowep
commented
Sep 4, 2024
- Fixes error for SLSP imports with incorrect 008.
ef5fbdd to
ce2aa7d
Compare
PascalRepond
requested changes
Sep 5, 2024
| self["fiction_statement"] = DocumentFictionType.Fiction.value | ||
| elif value[33] in ["0", "e", "h", "i", "s"]: | ||
| self["fiction_statement"] = DocumentFictionType.NonFiction.value | ||
| if len(value) >= 33: |
Contributor
There was a problem hiding this comment.
Should be ">33" because if len(value) == 33, value[33] will be an error
ce2aa7d to
bc8ba63
Compare
PascalRepond
approved these changes
Sep 5, 2024
* Fixes error for SLSP imports with incorrect 008. Co-Authored-by: Peter Weber <[email protected]>
bc8ba63 to
f5eb134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.