Thanks to visit codestin.com
Credit goes to github.com

Skip to content

documents: allow delete of documents with order lines #3818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from
Draft

documents: allow delete of documents with order lines #3818

wants to merge 1 commit into from

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jan 29, 2025

@rerowep rerowep self-assigned this Jan 29, 2025
@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: search dev: documentation About changelog, release notes, installation procedures, gh templates... f: user management f: data migration Data migration from a legacy system or a previous version dev: fixtures Fixtures data used for ils.test and ilsdev.test dev: DB Database structure (models.py) labels Jan 29, 2025
@rerowep rerowep marked this pull request as draft February 11, 2025 08:13
@rerowep rerowep force-pushed the wep-allow-delete-order-lines branch from 2d01ef7 to 3919b10 Compare February 13, 2025 10:19
@github-actions github-actions bot added f: permissions Concerns the rights management f: statistics Related to the usage statistics either for pricing or for the libaries reports labels Feb 13, 2025
@github-actions
Copy link

This PR is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Aug 13, 2025
@PascalRepond PascalRepond removed the stale Stale or no longer relevant label Aug 13, 2025
@rerowep rerowep force-pushed the wep-allow-delete-order-lines branch from 3919b10 to 6d3a96b Compare September 22, 2025 08:42
@github-actions github-actions bot removed f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: search dev: documentation About changelog, release notes, installation procedures, gh templates... f: user management f: permissions Concerns the rights management f: data migration Data migration from a legacy system or a previous version dev: fixtures Fixtures data used for ils.test and ilsdev.test f: statistics Related to the usage statistics either for pricing or for the libaries reports dev: DB Database structure (models.py) labels Sep 22, 2025
@rerowep rerowep marked this pull request as ready for review September 22, 2025 08:43
@coveralls
Copy link

coveralls commented Sep 22, 2025 •
edited
Loading

Coverage Status

coverage: 91.928%. remained the same
when pulling 13c0dda on rerowep:wep-allow-delete-order-lines
into ccfbf29 on rero:staging.

@PascalRepond
Copy link
Contributor

PascalRepond commented Sep 23, 2025 •
edited
Loading

PO tests

  • REP: Once I deleted a document, there is an error when displaying the corresponding order line and the receipt line doesn't load see. This needs a PR on rero-ils-ui to take that into account.

@rerowep rerowep marked this pull request as draft September 25, 2025 14:53
@rerowep
documents: allow delete of documents with orderln.
13c0dda 
* Closes rero#3225.
* Allows deletion of documents with acquisition order lines with status
  recieved or cancelled.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-allow-delete-order-lines branch from 6d3a96b to 13c0dda Compare September 29, 2025 06:09
@jma jma removed their request for review October 2, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

@PascalRepond PascalRepond Awaiting requested review from PascalRepond

At least 1 approving review is required to merge this pull request.

Assignees

@rerowep rerowep

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

documents: allow deletion if attached order lines are cancelled or recieved

3 participants

@rerowep @coveralls @PascalRepond