fix import path trimming during main.go generation #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The importPathFromPath function invoked during `revel build` in callchain Build -> ProcessSource -> importPathFromPath assumes that the vendor folder is in the app's root directory when trimming import paths for inclusion into autogenerated templates. Consequently vendor detection fails if the vendor folder is located at another hiher layer in the directory tree and /prefix/path/to/vendor/ is not stripped from the import path, leading to inclusion of invalid importpaths, resulting in compilation error and build abortion. This fix makes the vendor folder detection more flexible, allowing for the vendor folder to be present at any higher level in the directory hirachy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
importPathFromPathfunction invoked duringrevel buildin callchain
Build->ProcessSource->importPathFromPathassumes that the vendor folder is in the app's root directory
when trimming import paths for inclusion into autogenerated
templates.
Consequently vendor detection fails if the vendor folder
is located at another higher layer in the directory tree
and /prefix/path/to/vendor/ is not stripped from the
import path, leading to inclusion of invalid importpaths,
resulting in compilation error and build abortion.
This fix makes the vendor folder detection more flexible,
allowing for the vendor folder to be present at any higher
level in the directory hirachy.