Adds path detection when loading modules #1162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Recommend passing in a flag from the revel/cmd to indicate the core app that revel is to add in all folders for modules that contain tests. Additional feature could be to filter tests by module |
|
@notzippy I kind of prefer doing that via It makes sense that if the module has a |
|
I was just thinking there is no need to include those folders if revel was not running any tests - so harness would pass in something indicating what mode it should be run in.. |
notzippy
approved these changes
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to consider the side effects. At the very least, this allows me to run my module's tests along side the main app's tests.
Also, we should refactor the "hack"; is there a better way to enables testing in an app other than a hard coded module check like this?
Is there a better way to enable tests per module?