Support deleting outdated comments in github-pr-review reporter #1804
Conversation
| } | ||
|
|
||
| func buildMetaComment(fprint string, toolName string) string { | ||
| func BuildMetaComment(fprint string, toolName string) string { |
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
exported function BuildMetaComment should have comment or be unexported
| @@ -1,4 +1,4 @@ | |||
| Custom text for testing | |||
| Custom text for testing! | |||
There was a problem hiding this comment.
[custom-rdjson] reported by reviewdog 🐶
test comment for deleting outdated comment 2
There was a problem hiding this comment.
If there is a reply, this outdated comment should not be deleted.
This reverts commit ac36097.
|
before: |
|
After: |
| // Do not remove comment with replies. | ||
| continue |
There was a problem hiding this comment.
I think it would be easier to understand that reviewdog create a reply like This review comment has been resolved. if there is a outdated review comment with replies.
There was a problem hiding this comment.
Thanks, I agree with you to some extent, but if we'll create a reply comment, then we need to check whether we already have the reviewdog reply or not to avoid posting duplicated replies.
It needs extra logic and maitainance cost. I prefer keeping it as-is, at least for now, unless we have a simple way to handle this problem.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ICHINOSE Shogo <[email protected]>
| } | ||
|
|
||
| func buildMetaComment(fprint string, toolName string) string { | ||
| func BuildMetaComment(fprint string, toolName string) string { |
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
exported function BuildMetaComment should have comment or be unexported
This adds a quality-of-life change of closing outdated discussions: reviewdog/reviewdog#1804
This adds a quality-of-life change of closing outdated discussions: reviewdog/reviewdog#1804
Since reviewdog/reviewdog#1804, If you run multiple instances of this action there is a risk pr comments created by one are deleted by another. By providing a different name, we should not see this happen
Since reviewdog/reviewdog#1804, If you run multiple instances of this action there is a risk pr comments created by one are deleted by another. By providing a different name, we should not see this happen
Fix #568