Adjust paths with GitRelWorkdir for all GitHub reporters #1903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haya14busa
reviewed
Sep 7, 2024
Member
haya14busa
left a comment
There was a problem hiding this comment.
Sry for the late review. LGTM! Thank you for your contribution!
Can you update CHANGELOG?
Member
|
Hi, @chitoku-k! We merged your PR to reviewdog! 🐶 We just invited you to join the @reviewdog organization on GitHub. Thanks again! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, reviewdog adjusts result paths only with the
github-pr-reviewreporter within GitHub reporters. This is required if the linting is executed inside a sub directory and the result contains path(s) relative to that directory. The following line is where thegithub-pr-reviewreporter adjusts the paths:https://github.com/reviewdog/reviewdog/blob/v0.20.1/service/github/github.go#L107-L108
This PR tries to fix this by adding the same procedure for
githubservice.Check(github-checkandgithub-pr-check) as well as addinggithubservice.Logthat just does this adjustment. Note that adding this procedure togithubutils.GitHubActionLogWriterwould break the fallback flow, which is why I added newgithubservice.Loginstead.