Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update AWS GoSDK to v1.12.46 #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2017
Merged

update AWS GoSDK to v1.12.46 #1128

merged 1 commit into from
Dec 14, 2017

Conversation

@codenrhoden
Copy link
Member

This patch updates the AWS GoSDK from 1.10.38 to 1.12.46.

This is hopes of resolving #1118, where EBS volumes in a CN region are not working correctly.

This is currently untested, as I have not tried spinning up volumes in a CN region, and I still need to check that existing functionality is restored.

@codenrhoden codenrhoden added this to the 2017.12-2 milestone Dec 13, 2017
@akutz
Copy link
Member

akutz commented Dec 13, 2017

Hi @codenrhoden,

Why did you update the GoCSI info in Gopkg.toml instead of just using dep ensure -update to update AWS directly?

@codenrhoden
Copy link
Member Author

LOL, I meant to explain that... Totally forgot.

So, if I ran dep ensure -update, with the AWS library, I got all kinds of resolver errors. Tried a bunch of trial and error, and flat out could not get it to work until I locked down both GoCSI and csi-vfs. Maybe I should have tried to look for an updated version of dep first, but it's been working so well lately...

@akutz
Copy link
Member

akutz commented Dec 13, 2017

Hi @codenrhoden,

I'm curious what resolver errors you received. Hmm.

@akutz
Copy link
Member

akutz commented Dec 13, 2017

Hi @codenrhoden,

Something like this?

$ dep ensure -update github.com/aws/aws-sdk-go
Solving failure: No versions of github.com/thecodeteam/gocsi met constraints:
	master: Could not introduce github.com/thecodeteam/gocsi@master, as its subpackage github.com/thecodeteam/gocsi/csp is missing. (Package is required by github.com/thecodeteam/csi-vfs@master.)
	v0.2.4: Could not introduce github.com/thecodeteam/[email protected] due to multiple problematic subpackages:
	Subpackage github.com/thecodeteam/gocsi/csi is missing. Package is required by:
		(root)
		github.com/thecodeteam/csi-blockdevices@master	Subpackage github.com/thecodeteam/gocsi/mount is missing. Package is required by:
		(root)
		github.com/thecodeteam/csi-blockdevices@master
	v0.2.3: Could not introduce github.com/thecodeteam/[email protected], as it is not allowed by constraints from the following projects:
	master from (root)
	master from github.com/thecodeteam/csi-vfs@master
	master from github.com/thecodeteam/csi-blockdevices@master

	v0.2.2: Could not introduce github.com/thecodeteam/[email protected], as it is not allowed by constraints from the following projects:
	master from (root)
	master from github.com/thecodeteam/csi-vfs@master
	master from github.com/thecodeteam/csi-blockdevices@master

	v0.2.1: Could not introduce github.com/thecodeteam/[email protected], as it is not allowed by constraints from the following projects:
	master from (root)
	master from github.com/thecodeteam/csi-vfs@master
	master from github.com/thecodeteam/csi-blockdevices@master

	v0.2.0: Could not introduce github.com/thecodeteam/[email protected], as it is not allowed by constraints from the following projects:
	master from (root)
	master from github.com/thecodeteam/csi-vfs@master
	master from github.com/thecodeteam/csi-blockdevices@master

	v0.1.0: Could not introduce github.com/thecodeteam/[email protected], as it is not allowed by constraints from the following projects:
	master from (root)
	master from github.com/thecodeteam/csi-vfs@master
	master from github.com/thecodeteam/csi-blockdevices@master

	master: Could not introduce github.com/thecodeteam/gocsi@master due to multiple problematic subpackages:
	Subpackage github.com/thecodeteam/gocsi/csi is missing. Package is required by:
		(root)
		github.com/thecodeteam/csi-blockdevices@master	Subpackage github.com/thecodeteam/gocsi/mount is missing. Package is required by:
		(root)
		github.com/thecodeteam/csi-blockdevices@master

@akutz
Copy link
Member

akutz commented Dec 13, 2017

Hi @codenrhoden,

So, you did the right thing. What occurred is that dep tries to build the object graph for the project's dependencies. The entire graph. Even if it's just to update a single, versioned dependency. This is necessary to ensure that the updated version doesn't introduce a conflict to the existing graph. However, due to the existing constraints around GoCSI the graph cannot be produced.

So yeah, you did the right thing.

@codecov-io
Copy link

codecov-io commented Dec 13, 2017 •
edited
Loading

Codecov Report

Merging #1128 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
+ Coverage   34.54%   34.58%   +0.04%     
==========================================
  Files          36       36              
  Lines        2362     2362              
==========================================
+ Hits          816      817       +1     
+ Misses       1442     1441       -1     
  Partials      104      104
Impacted Files Coverage Δ
libstorage/api/types/types_localdevices.go 85.96% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 282a09a...505a4af. Read the comment docs.

@codenrhoden codenrhoden force-pushed the enhancement/update_awsgosdk branch from 1fda67a to 505a4af Compare December 14, 2017 21:31
@codenrhoden
Copy link
Member Author

Took this for a spin on AWS today. no regressions found (wasn't expecting any, the go library is pretty stable), as I was able to do the normal create/attach/detach/remove cycle just fine.

I tried to use the cn-north-1 region, but got messages that EC2 is not available in that region. Not sure what it takes to get access to it. Once CI completes, I plan to merge this. Then I'll ping @spatialvlad and see if he able to take the unstable build for a spin to see if it resolves his issue. He indicated that it might not, as the AWS GoSDK we were using should have already supported the region... But, updating it is worth a shot.

@codenrhoden codenrhoden merged commit bf500f3 into rexray:master Dec 14, 2017
@codenrhoden codenrhoden deleted the enhancement/update_awsgosdk branch December 14, 2017 22:40
@codenrhoden codenrhoden self-assigned this Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@codenrhoden codenrhoden

Labels

ebs

Projects

None yet

Milestone

2017.12-2

Development

Successfully merging this pull request may close these issues.

3 participants

@codenrhoden @akutz @codecov-io