Fix keymap tick-less input handling #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
FWIW, Not all overflows are ignored... e.g. if more than max_pressed_keys are pressed at once, the firmware will still panic. I'm not sure how 'robust' I want the keymap firmware to be against all these cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple implementation for split keyboard code will: have the keymap handle events from the matrix scanning; and not
tick()the keymap if the report hasn't sent over USB. -- This results in the keymap's input queue overflowing.This PR adds a motivating test case which demonstrates the issue, and fixes this in the code.