Add Key: Caps Word #259
Merged
Add Key: Caps Word #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Tried on the keyboard. Works. |
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a new CapsWord key mode into the keymap system and updates related modules, tests, and documentation. Key changes include:
- Adding new modules and tests for CapsWord functionality (tests/rust/caps_word.rs)
- Updating composite modules and BaseKey to integrate CapsWord
- Extending context and event conversions to support CapsWord handling
Reviewed Changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/rust/keymap.rs | Added module import for caps_word in tests |
| tests/rust/caps_word.rs | Introduced tests to validate CapsWord key behavior |
| src/key/mod.rs | Declared the new caps_word module |
| src/key/doc_de_caps_word.md | Provided CapsWord JSON documentation example |
| src/key/composite/tap_hold.rs | Extended TapHoldNestable to include CapsWord keys |
| src/key/composite/base.rs | Integrated CapsWord into BaseKey and key trait implementations |
| src/key/composite.rs | Updated context and event conversions to include caps_word context |
| src/key/caps_word.rs | Added the implementation and state handling for the CapsWord key |
Files not reviewed (4)
- ncl/key-extensions.ncl: Language not supported
- ncl/keymap-codegen.ncl: Language not supported
- ncl/keymap-ncl-to-json.ncl: Language not supported
- ncl/keys.ncl: Language not supported
| _key_path: key::KeyPath, | ||
| _event: key::Event<Self::Event>, | ||
| ) -> (Option<Self::KeyState>, key::PressedKeyEvents<Self::Event>) { | ||
| panic!() |
There was a problem hiding this comment.
The handle_event implementation for caps_word::Key currently panics, which may lead to runtime crashes if an event is inadvertently passed to it. Consider implementing proper event handling or providing a clear explanation (e.g., using todo!() with a comment) to ensure production stability.
Suggested change
| panic!() | |
| // TODO: Implement proper event handling for caps_word::Key | |
| todo!() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.