Merged
Conversation
f66d053 to
2d847fc
Compare
alexandrebrg
requested changes
Apr 24, 2023
Member
alexandrebrg
left a comment
There was a problem hiding this comment.
Overall that's great to have this kind of changes, it improves the code!
Still, I think the current changes don't match how we should be handling errors with public facing APIs, please check my comment about RikError to discuss it.
Signed-off-by: Malo Polese <[email protected]>
Signed-off-by: Malo Polese <[email protected]>
Signed-off-by: Malo Polese <[email protected]>
Signed-off-by: Malo Polese <[email protected]>
Signed-off-by: Malo Polese <[email protected]>
2d847fc to
8acf04a
Compare
alexandrebrg
approved these changes
May 10, 2023
Member
alexandrebrg
left a comment
There was a problem hiding this comment.
Nit change, otherwise LGTM
Signed-off-by: Malo Polese <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
Better error handling in controller
✅ Checks
ℹ Additional Information