Support inline expression with casting#1419
Merged
Conversation
e259090 to
291fc6b
Compare
latonz
requested changes
Aug 3, 2024
Contributor
latonz
left a comment
There was a problem hiding this comment.
Thank you very much for this contribution, I added my feedback 😊
test/Riok.Mapperly.Tests/Helpers/InlineExpressionRewriterTest.cs
Outdated
Show resolved
Hide resolved
291fc6b to
3af5f54
Compare
3af5f54 to
b64f8be
Compare
latonz
approved these changes
Aug 5, 2024
b64f8be to
6e43ca4
Compare
Contributor
|
Thank you for this contribution! |
Contributor
Author
|
Thank you for processing it. Is it possible to publish a new release? A pre-release is fine for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support inline expression with casting
Description
When using
Use = nameof(), which contains casting, e.g.((MyEnum) value & MyEnum.OptionA) > 0generated mapping does not resolve the fully qualified type of the casted type.Checklist