I'm still struggling with the unittest for RMG90 when setting SuppressNullMismatchDiagnostic to true, that test is failing cause the configation of the SuppressNullMismatchDiagnostic stays false, but I can't figure out why. Anyone able to help with this?

I'm still struggling with the unittest for RMG90 when setting SuppressNullMismatchDiagnostic to true, that test is failing cause the configation of the SuppressNullMismatchDiagnostic stays false, but I can't figure out why. Anyone able to help with this?

You should be able to debug this by adding a conditional breakpoint in Riok.Mapperly.Diagnostics.DiagnosticCollection.ReportDiagnostic and setting the condition to the diagnostic id you want to debug (e.g. descriptor.Id == "RMG090"). With this breakpoint, you can debug the failing unit test. Once the breakpoint is hit, you can walk up the stack trace to identify why the diagnostic was reported.

I'm still struggling with the unittest for RMG90 when setting SuppressNullMismatchDiagnostic to true, that test is failing cause the configation of the SuppressNullMismatchDiagnostic stays false, but I can't figure out why. Anyone able to help with this?

You should be able to debug this by adding a conditional breakpoint in Riok.Mapperly.Diagnostics.DiagnosticCollection.ReportDiagnostic and setting the condition to the diagnostic id you want to debug (e.g. descriptor.Id == "RMG090"). With this breakpoint, you can debug the failing unit test. Once the breakpoint is hit, you can walk up the stack trace to identify why the diagnostic was reported.

Yes, I have already done that, but I find it too complex to find out why SuppressNullMismatchDiagnostic remains false here (although i specify it in the test as true)

I think it's cause in the unittest the TypeMappingConfiguration.Default is used (i believe this is the same as @kakone says here above)

The NullableTypeWithSuppressNullMismatchDiagnosticTrueShouldIgnoreWarningRMG090 test fails due to the following:

• [MapProperty(\"IdA\", \"IdB\", SuppressNullMismatchDiagnostic = true)] ignores RMG089 for the mapping of the property IdA to IdB
• The user-defined mapping B Map(A? source) also has a null mismatch. The RMG090 gets emitted for this mapping, but not for the property mapping IdA => IdB.

So RMG090 is always emitted on a type mapping but not on a member mapping. So I'm not sure whether it makes sense to suppress it via a member on the MapProperty attribute as it is not related to a member. Couldn't these RMG090 already be suppressed with a SuppressMessage attribute? Otherwise we would need to think about adding SuppressNullMismatchDiagnostic to the UserMapping attribute 🤔

The NullableTypeWithSuppressNullMismatchDiagnosticTrueShouldIgnoreWarningRMG090 test fails due to the following:

• [MapProperty(\"IdA\", \"IdB\", SuppressNullMismatchDiagnostic = true)] ignores RMG089 for the mapping of the property IdA to IdB
• The user-defined mapping B Map(A? source) also has a null mismatch. The RMG090 gets emitted for this mapping, but not for the property mapping IdA => IdB.

So RMG090 is always emitted on a type mapping but not on a member mapping. So I'm not sure whether it makes sense to suppress it via a member on the MapProperty attribute as it is not related to a member. Couldn't these RMG090 already be suppressed with a SuppressMessage attribute? Otherwise we would need to think about adding SuppressNullMismatchDiagnostic to the UserMapping attribute 🤔

I was just trying to do what was said in #1613 . So if I understand, correctly, this ain't possible with the MapProperty attribute for RMG090?

@3sRykaert When I wrote the issue, I didn't conduct a thorough analysis. In my opinion, it works for RMG090 when dealing with generated mappings, but not for user-defined mappings.

@latonz maybe we can then split up the issues in 2 separate ones:

• one for RMG089 which can be this
• and one for RM090 which is still todo

If you agree, I'll adjust the code to only keep RMG089 into account.