Conversation
latonz
reviewed
Jul 10, 2025
Contributor
latonz
left a comment
There was a problem hiding this comment.
Thank you for your contribution and efforts!
Since this introduces a breaking change, we'll postpone merging it until fall, when we plan to include it in our next scheduled breaking-change release (together with other breaking changes).
Contributor
Author
|
@latonz I've updated the unit tests now and removed the explicit casting where applicable and used All for any other cases. I've also removed the extra parameters in the TestOptions class and simplified it to have options for the All Conversion Type only. This should hopefully simplify the test cases. |
latonz
requested changes
Jul 14, 2025
Contributor
latonz
left a comment
There was a problem hiding this comment.
Thank you for the updates! I have a couple of small nitpicks.
latonz
previously approved these changes
Jul 15, 2025
fd188e4 to
0dd0244
Compare
…ll conversion types except ExplicitCast. Co-authored-by: Lars <[email protected]>
0dd0244 to
f1cfaef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Default MappingTypeConversion
Description
Added a new flag for a Default MappingTypeConversion, this is a breaking change that will set the default configuration for a mapper to exclude the ExplicitCast Conversion, this will prevent accidental data loss for Explicit Casting.
A lot of the changes are in the test cases, I had to "Explicitly" Add the flags to correctly test the new behavior on existing test cases to ensure they would work
Fixes #1638
Checklist