Add OnlyExplicitMappedMembers implementation #2001
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latonz
requested changes
Oct 31, 2025
Contributor
latonz
left a comment
There was a problem hiding this comment.
Thank you for your contribution, I added my feedback.
Comment on lines
+187
to
+189
| var target = new global::B(); | ||
| target.Value1 = source.Value1; | ||
| target.Value2 = source.Value2; |
Contributor
There was a problem hiding this comment.
According to the description on the configuration member:
When set to true, only properties with explicit configurations (via attributes like MapProperty) will be mapped. All other properties will be ignored by default.
all members should be ignored, even if the match exactly, except if they are mapped explicitly. This isn't the case here and in the other tests, is it?
| } | ||
|
|
||
| [Fact] | ||
| public void OnlyExplicitMappedMembersWithExtraSourceMembers() |
Contributor
There was a problem hiding this comment.
Also add tests with explicit mappings (MapProperty, MapPropertyFromSource, ...)
| public bool AutoUserMappings { get; set; } = true; | ||
|
|
||
| /// <summary> | ||
| /// When set to <c>true</c>, only properties with explicit configurations (via attributes like <c>MapProperty</c>) |
Contributor
There was a problem hiding this comment.
Use see tag for the MapProperty attribute
Contributor
|
Closing for now as no update was received for several weeks... Feel free to reopen with updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OnlyExplicitMappedMembers Configuration Option
Description
First, I want to express my gratitude for the beautiful library and the excellent work that has been done in Mapperly. This library has been incredibly useful!
This PR introduces a new
OnlyExplicitMappedMembersconfiguration option to theMapperAttributethat allows mapping only properties with explicit configurations (via attributes likeMapProperty). All other properties will be ignored by default when this option is enabled.This feature is particularly useful when working with classes that have many properties but you only need to map a few specific ones, providing a more declarative and maintainable approach compared to explicitly ignoring every unwanted property.
Changes made:
OnlyExplicitMappedMembersproperty toMapperAttributeMapperConfigurationand merger logicIgnoredMembersBuilderto automatically ignore non-matching members when this option is enabledFixes #1981
Checklist