I am wondering if technicallyyyy this could be considered a breaking change? Only in the situation if someone had a default FormatProvider defined for use in ToString, and was relying on the fact that Parse was not using that FormatProvider, this update would change that behaviour

@Nysosis yes, that's definitely a breaking change.
Currently ToString -> Parse doesn't roundtrip.
With this change it will.

You are absolutely right, this is definitely a breaking change. We plan to release the next breaking change with all open breaking change PR's (and maybe some other breaking changes) at the beginning of next year.
Planning to merge this as soon as this PR is ready and 4.3.1 or 4.4.0 is released.

With regards to those breaking integration tests for framework and net8 @latonz, is this a case of 'You may need to manually update older versions' ? As when I'm running the integration tests via VS or dotnet test do not fail or make changes to those snapshots

With regards to those breaking integration tests for framework and net8 @latonz, is this a case of 'You may need to manually update older versions' ? As when I'm running the integration tests via VS or dotnet test do not fail or make changes to those snapshots

You'd need to run these tests with .NET 8.0/.NET Framework... However, usually it is easier to download the artifacts from the GitHub Actions Artifacts (you can find these here), extract and merge into your source, review the received/verified files and approve & commit them if ok.

Should the the tests for net6 and net7 be running on the GH pipelines? As it's not finding any:

A total of 1 test files matched the specified pattern.
No test is available in /__w/mapperly/mapperly/test/Riok.Mapperly.IntegrationTests/bin/Debug/net7.0/Riok.Mapperly.IntegrationTests.dll. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.

Noticed because I would have expected the snapshot verifications for 6&7 to also change (because they also support the formatprovider on int/guid parse) - if I change the sample project locally to be net 6.0 and add a format provider than the generated carmapper uses it.

Should the the tests for net6 and net7 be running on the GH pipelines? As it's not finding any:

A total of 1 test files matched the specified pattern.
No test is available in /__w/mapperly/mapperly/test/Riok.Mapperly.IntegrationTests/bin/Debug/net7.0/Riok.Mapperly.IntegrationTests.dll. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.

Noticed because I would have expected the snapshot verifications for 6&7 to also change (because they also support the formatprovider on int/guid parse) - if I change the sample project locally to be net 6.0 and add a format provider than the generated carmapper uses it.

Oh wow, I’m curious how long these haven’t been running. I’ll look into it. Since .NET 6 and 7 are no longer supported by Microsoft, we’re planning to drop support for them in Mapperly with the next breaking release. Because this will also be a breaking change, there’s nothing you need to worry about right now. Thanks for letting me know!

Oh wow, I’m curious how long these haven’t been running. I’ll look into it. Since .NET 6 and 7 are no longer supported by Microsoft, we’re planning to drop support for them in Mapperly with the next breaking release. Because this will also be a breaking change, there’s nothing you need to worry about right now. Thanks for letting me know!

I think it's the version of xunit.runner.visualstudio doing it, I dropped it down to 2.8.2 and was eventually able to get it running the net6 tests when using some dotnet command line arguments magic, but good to know I don't need to worry about them.

Will push up the framework/net8 snapshot changes :)