Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@MokOopsing
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@MokOopsing MokOopsing marked this pull request as ready for review March 4, 2024 08:29
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@ksqsf ksqsf merged commit edee320 into rime:master Mar 4, 2024
@MokOopsing MokOopsing deleted the fix_android_permission branch March 4, 2024 15:09
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants